-
Notifications
You must be signed in to change notification settings - Fork 19.6k
[Keras 3 OpenVINO Backend]: Support numpy.flip operation #21410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21410 +/- ##
==========================================
+ Coverage 82.67% 82.72% +0.05%
==========================================
Files 565 565
Lines 55073 55239 +166
Branches 8571 8612 +41
==========================================
+ Hits 45532 45698 +166
+ Misses 7443 7429 -14
- Partials 2098 2112 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@Mohamed-Ashraf273, could you please review this PR? Thanks |
indices = ov_opset.range(start, stop, step, Type.i64).output(0) | ||
flipped = ov_opset.gather( | ||
flipped, indices, ov_opset.constant(ax, Type.i64).output(0) | ||
).output(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend considering the use of strided_slice
instead of building reversed indices with range
and gather
for each axis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Imokutmfon, please use ReverseSequence operation: https://docs.openvino.ai/2025/documentation/openvino-ir-format/operation-sets/operation-specs/movement/reverse-sequence-1.html
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
implementation for numpy.flip using openvino ops
please review @rkazants
Fixes openvinotoolkit/openvino#29359